Repository navigation
Libraries by URL in share links; notes for broken and long links (#29, onto main) - #30
Merged
Merged
Conversation
Share links of version 2 name a library by its URL instead of carrying its
code ({path, url, readOnly: true}), so an Etappe 4 link with parser.py has
about 1,200 characters instead of 5,157. The IDE fetches a library once when
the link opens (https or http on localhost, at most 1 MB, without cookies)
and keeps its text with the tab's project, so reload and offline use the
copy. The file drawer lists it under «Bibliotheken» with its host and a
lock; a library that can't be loaded (HTTP status, network error,
timeout, too large) is named in the drawer and a notice with «Erneut
versuchen», and importing it raises Python's own ModuleNotFoundError, as
in the LiaScript macro. «Teilen» names it by URL again; the ZIP holds its
code and lists its URL in glpython.json. Links without libraries stay
version 1, and links of version 1 open as before.
A link that can't be read (cut off, e.g. by OneNote at 2,083 characters,
or damaged) opens an empty project with «Dieser Link ist unvollständig oder
beschädigt. …» - never another project.
«Teilen» still copies a link longer than 2,083 characters, with a note to
download the project for a hand-in and a «Herunterladen» button.
The unsaved-changes fingerprint ignores read-only files: a library
arriving after its fetch is no change of the learner's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Libraries by URL in share links; notes for broken and long links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR carries the reviewed changes of #29 (libraries by URL in share links, notes for broken and long links) onto
main. #29 was merged into its stacked basefeature/tab-projects(merge commitab88f51) before GitHub switched that base tomain, so its changes aren't live yet. Review and wording: see #29.Checked
main...feature/tab-projectsis byte-identical to Libraries by URL in share links; notes for broken and long links #29's own diff (7ee17d3..146e68f). 9 files, +277/−56:src/libraries.ts(new),projectShare.ts,projectStorage.ts,tabProjects.ts,App.tsx,i18n.ts,index.css, README, CLAUDE.md. Nothing from Per-tab projects, «Zuletzt geschlossen», new-version notice #28 appears twice.f29d250(bump to glpython-editor v0.1.20, merged with Per-tab projects, «Zuletzt geschlossen», new-version notice #28). The PR doesn't touchpackage.jsonorpackage-lock.json, and a test merge intomainkeepsglpython-editor#v0.1.20.main(git merge-tree) gives exactly the tree offeature/tab-projects.Order: merging deploys #29's changes. Merge the macro PR glpython-edu/glpython-liascript#26 only after that deploy: an IDE before it can't read the macro's version 2 links.
🤖 Generated with Claude Code